Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13415: Update left shift #15538

Merged
merged 1 commit into from
Dec 1, 2024
Merged

#13415: Update left shift #15538

merged 1 commit into from
Dec 1, 2024
+6 −14

Conversation

VirdhatchaniKN
Copy link
Contributor

@VirdhatchaniKN VirdhatchaniKN commented Nov 28, 2024 •
edited
Loading

Ticket

#13415

Problem description

Update left shift

What's changed

Updated file as mentioned in Issue #15514.

Checklist

@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/left_shift_change branch from 0909d83 to 56602f7 Compare November 28, 2024 11:50
Aswinmcw
Aswinmcw approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@Aswinmcw Aswinmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VirdhatchaniKN VirdhatchaniKN marked this pull request as ready for review November 28, 2024 16:40
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/left_shift_change branch 2 times, most recently from 7f88832 to e336021 Compare November 28, 2024 19:12
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/left_shift_change branch from e336021 to 7b29d34 Compare November 30, 2024 13:05
@VirdhatchaniKN VirdhatchaniKN mentioned this pull request Nov 30, 2024
Closed
@VirdhatchaniKN VirdhatchaniKN linked an issue Nov 30, 2024 that may be closed by this pull request
ttnn.bitwise_left_shift gives results different from the torch version when the bit used to represent a sign differs from the bit on position 31 - shift_bits #13415
Closed
@VirdhatchaniKN
Copy link
Contributor Author

https://github.com/tenstorrent/tt-metal/actions/runs/12097803013 - passed

@VirdhatchaniKN VirdhatchaniKN merged commit 7b74c5b into main Dec 1, 2024
347 of 350 checks passed
@VirdhatchaniKN VirdhatchaniKN deleted the virdhatchani/left_shift_change branch December 1, 2024 05:53
nathan-TT added a commit that referenced this pull request Feb 5, 2025
@nathan-TT
Revert "#13415: Update left shift (#15538)"
d9e8a84 
This reverts commit 7b74c5b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umadevimcw umadevimcw umadevimcw approved these changes

@Aswinmcw Aswinmcw Aswinmcw approved these changes

@rdjogoTT rdjogoTT rdjogoTT approved these changes

@mcw-anasuya mcw-anasuya mcw-anasuya approved these changes

@rtawfik01 rtawfik01 Awaiting requested review from rtawfik01 rtawfik01 is a code owner

@ttmtrajkovic ttmtrajkovic Awaiting requested review from ttmtrajkovic ttmtrajkovic is a code owner

@eyonland eyonland Awaiting requested review from eyonland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@VirdhatchaniKN @umadevimcw @Aswinmcw @rdjogoTT @mcw-anasuya